Feature(#82) replace deprecated data with MDEB datasets - #83
Conversation
jmhatch
left a comment
jmhatch
left a comment
There was a problem hiding this comment.
PR looks good!
The _pkgdown.yml was modified to remove the deprecated data and add the replacement data.
The following data were replaced:
- BTS_Strata -> bts_strata
- Ecomon_Strata -> ecomon_strata
- Shrimp_Strata -> shrimp_strata
The following data were added:
- ecomon_stations
The following data were removed:
- Shellfish_Strata
I was able to locally build the pkg, and was able to successfully load and plot the data. Data documentation and pkgdown site looked good. No obvious issues.
Might want to add an entry to NEWS.md to document the changes made in this PR, if you haven't already done so in another PR.
Also, the workflow used to update the mdeb datasets wasn't clear. I saw a yaml file in the .github folder, but it looks like it isn't being implemented currently. Might want to document your process somewhere, or maybe automate it (which you may have already started?).
|
Thanks Josh, i will add changes to DESCRIPTION and NEWS.md in Regarding the creation of the MDEB data sets. This was from something we worked on a while back. The script is in We could start a discussion to walk through how we want to do that automation |
|
Yeah, I think you're right. And thanks for jogging my memory! It's been awhile since I looked at all of this, and I do vaguely remember that R code you pointed to. That addresses my question about workflow. Happy to help / discuss the automation. I guessed you had most of it started in that template. |
2 participants
Your commits explain the
who,what,whereandwhenof these changes. Your code shows thehow. You do not need to reiterate this. This PR should complete the picture by explainingwhythese changes are necessary.Justification
Several datasets are flagged as deprecated. There are replacement datasets in the MDEB gis datahub. Enough time has passed for users to prepare. This PR replaces those datasets and their documentation.
Fixes #82
Types of changes
What types of changes does this pull request introduce? Put an
xin the boxes that apply.This will inform the new release number.
Further comments
Changes to the pkgdown yml and the onload function have been removed.
Reviewer instructions
Please reinstall the package from this branch, and make sure the updated datasets are available. Run the
pkgdown::build_site()function and view the documentation for the removal of old and inclusion of new datasets.Note: there are many updates available for the datasets already in the package. These should be updated in another PR dedicated to an issue outlining this task
Do not commit any changes directly to the branch but make suggestions in this PR if changes are requested